Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan enums when using pgx #386

Merged
merged 6 commits into from
Mar 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -482,8 +482,7 @@ If you need to update a large number of expexted test output in the
`internal/endtoend/testdata` directory, run the `regenerate.sh` script.

```
cd internal/endtoend
./regenerate.sh
./scripts/regenerate.sh
```

## Acknowledgements
Expand Down
10 changes: 9 additions & 1 deletion examples/booktest/mysql/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion examples/booktest/postgresql/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion examples/ondeck/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion internal/dinosql/gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,9 @@ func modelImports(r Generateable, settings config.CombinedSettings) fileImports
if UsesType(r, "net.HardwareAddr", settings) {
std["net"] = struct{}{}
}
if len(r.Enums(settings)) > 0 {
std["fmt"] = struct{}{}
}

// Custom imports
pkg := make(map[string]struct{})
Expand Down Expand Up @@ -1144,7 +1147,14 @@ const (
)

func (e *{{.Name}}) Scan(src interface{}) error {
*e = {{.Name}}(src.([]byte))
switch s := src.(type) {
case []byte:
*e = {{.Name}}(s)
case string:
*e = {{.Name}}(s)
default:
return fmt.Errorf("unsupported scan type for {{.Name}}: %T", src)
}
return nil
}
{{end}}
Expand Down
3 changes: 0 additions & 3 deletions internal/endtoend/regenerate.sh

This file was deleted.

13 changes: 11 additions & 2 deletions internal/endtoend/testdata/enums/go/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 27 additions & 4 deletions internal/endtoend/testdata/mysql_enums/go/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion internal/endtoend/testdata/mysql_overrides/go/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion internal/endtoend/testdata/mysql_param/go/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion internal/endtoend/testdata/mysql_parse/go/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion internal/endtoend/testdata/ondeck/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 11 additions & 2 deletions internal/endtoend/testdata/schema_scoped_enum/go/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions scripts/regenerate.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
#!/usr/bin/env bash
set -x

for dir in internal/endtoend/testdata/*; do (cd "$dir" && sqlc-dev generate); done
for dir in examples/*; do (cd "$dir" && sqlc-dev generate); done