compiler: temp fix for typecast function parameters #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where a FuncCall has a TypeCast node as an argument, resolveCatalogRefs would erroneously output two parameters for that argument instead of one. This fix eliminates the duplicate param and allows queries with typecast function args to compile, but it loses track of the argument's connection with the function called. This means the parameters use the generic ColumnN names even when the function has named parameters. A future refactor of resolveCatalogRefs to better address function calls will be necessary to address the name issue. (this only edits the experimental package and does not fix the old dinosql compiler) Closes sqlc-dev#520
|
Does this look OK? |
|
Yes! I hit the "Merge master into branch" button and then forgot to merge. Doing so now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where a FuncCall has a TypeCast node as an
argument, resolveCatalogRefs would erroneously output
two parameters for that argument instead of one.
This fix eliminates the duplicate param and allows queries
with typecast function args to compile, but it loses track
of the argument's connection with the function called. This
means the parameters use the generic ColumnN names even when
the function has named parameters.
A future refactor of resolveCatalogRefs to better address
function calls will be necessary to address the name issue.
(this only edits the experimental package and does not fix
the old dinosql compiler)
Closes #520