Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate optparse to argparse #5590

Closed
wants to merge 2 commits into from
Closed

Conversation

NattyXO
Copy link

@NattyXO NattyXO commented Dec 25, 2023

  • I've made the improvement in the script by transitioning from optparse to argparse for command-line option parsing. This change aligns the codebase with recent Python standards, as argparse is the recommended module for parsing command-line arguments in current Python versions. This update ensures the script remains compatible and future-proof.

@stamparm
Copy link
Member

this wont' work. fix is far more complex

@stamparm stamparm closed this Dec 25, 2023
@stamparm
Copy link
Member

i'll do it later. wasn't even aware that this is an "issue", because it is/was sqlmapapi.py

@stamparm
Copy link
Member

p.s. just to not be a total prick, this is main main argument - patch that was done for sqlmap.py - 5650abb

@stamparm stamparm self-assigned this Dec 25, 2023
@stamparm
Copy link
Member

reopening just for me to have it in a "backlog"

@stamparm stamparm reopened this Dec 25, 2023
@sqlmapproject sqlmapproject locked and limited conversation to collaborators Dec 25, 2023
@stamparm stamparm closed this in 162bafa Jan 14, 2024
@stamparm stamparm added this to the 1.9 milestone Jan 14, 2024
MirMohammadd pushed a commit to MirMohammadd/sqlmap that referenced this pull request May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants