Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Allow one to specify a bind address for http, udp, fixes problem when udp disabled. #138

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

splbio
Copy link

@splbio splbio commented Oct 24, 2013

This is useful to only listen on loopback.

Syntax in your config would look like:
"http-addr": "127.0.0.1"

You can also specify a udp-addr now.

This is useful to only listen on loopback.

Syntax in your config would look like:
"http-addr": "127.0.0.1"
Otherwise we get a random port allocated.
@Marsup
Copy link

Marsup commented Oct 24, 2013

Dupe of #137 ?

@splbio
Copy link
Author

splbio commented Oct 24, 2013

Almost, this request includes 28d5571 which fixes where if udp port isn't specified then a random port isn't created.

Also I didn't see the pending pull of #137 when I wrote this sorry for the dup code!

@Marsup
Copy link

Marsup commented Oct 25, 2013

Oh I missed that. I recreated a commit in the merge we're doing (#129) with your name, it was harder to cherry-pick, hope you don't mind.

@splbio
Copy link
Author

splbio commented Oct 25, 2013

Do not mind at all. Enjoy and thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants