Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Order Events by time/data fields. #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

sbuss
Copy link

@sbuss sbuss commented Jul 8, 2012

Events can be ordered by the time or any of its data fields by adding an
'order=field' parameter to the query. 'order=-time' is the default.

Descending order can be specified by prepending "-" to the field name.

If the ordering field is "time" the field name is transformed to "t",
otherwise it is transformed to "d.{field_name}".

Fixes #79

(Resubmitting with the correct git user, sorry for the noise)

sbuss added 2 commits July 8, 2012 00:45
Events can be ordered by the time or any of its data fields by adding an
'order=field' parameter to the query. 'order=-time' is the default.

Descending order can be specified by prepending "-" to the field name.

If the ordering field is "time" the field name is transformed to "t",
otherwise it is transformed to "d.{field_name}".
The tests revealed a bug in the previous commit which added the order
parameter, which has now been fixed.
@sbuss
Copy link
Author

sbuss commented Jul 8, 2012

I'm not much of a JS developer so it took me some time to wrap my head around all of the callbacks in the unit tests, but I managed to write some tests for events. The tests even exposed a problem in my pull request.

@sbuss
Copy link
Author

sbuss commented Jul 24, 2012

Is there anything I might change with this PR to help it get merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant