Evict connection pool a second time after tests (#7819)

square · May 14, 2023 · e2344c7 · e2344c7
1 parent f62fd47
commit e2344c7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/okhttp-testing-support/src/jvmMain/kotlin/okhttp3/OkHttpClientTestRule.kt b/okhttp-testing-support/src/jvmMain/kotlin/okhttp3/OkHttpClientTestRule.kt
@@ -190,6 +190,7 @@ class OkHttpClientTestRule : BeforeEachCallback, AfterEachCallback {
         println("After delay: " + connectionPool.connectionCount())
       }
 
+      connectionPool.evictAll()
       assertEquals(0, connectionPool.connectionCount()) {
         "Still ${connectionPool.connectionCount()} connections open"
       }

diff --git a/okhttp/src/jvmTest/java/okhttp3/internal/ws/WebSocketHttpTest.java b/okhttp/src/jvmTest/java/okhttp3/internal/ws/WebSocketHttpTest.java
@@ -909,11 +909,6 @@ private OkHttpClientTestRule configureClientTestRule() {
 
   /** https://github.com/square/okhttp/issues/7768 */
   @Test public void reconnectingToNonWebSocket() throws InterruptedException {
-    // Async test is problematic
-    client = this.client.newBuilder()
-            .connectionPool(new ConnectionPool())
-            .build();
-
     for (int i = 0; i < 30; i++) {
       webServer.enqueue(new MockResponse.Builder()
         .bodyDelay(100, TimeUnit.MILLISECONDS)
@@ -950,8 +945,6 @@ public void onFailure(WebSocket webSocket, Throwable t, Response response) {
     for (WebSocket webSocket: webSockets) {
       webSocket.cancel();
     }
-    client.dispatcher().cancelAll();
-    client.connectionPool().evictAll();
   }
 
   @Test public void compressedMessages() throws Exception {