Add support for OkHttp's MultipartBody.Part. #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
force-pushed
the
jw/multipart-part-parts
branch
from
b44284b
to
b5a71c4
Compare
To do this we need to make `@Part`'s value (i.e., name) optional, since `MultipartBody.Part` brings its name. `MultipartBody.Part` is a replacement for Retrofit 1's `TypedOutput`/`TypedFile` for doing uploads of files with names.
JakeWharton
force-pushed
the
jw/multipart-part-parts
branch
from
b5a71c4
to
28d3d65
Compare
| retrofit.requestBodyConverter(type, annotations, methodAnnotations); | ||
| return new ParameterHandler.Part<>(headers, converter); | ||
| Headers headers = | ||
| Headers.of("Content-Disposition", "form-data; name=\"" + partName + "\"", |
There was a problem hiding this comment.
Probably want to eventually restrict this to not contain ", etc.
Or escape it somehow
swankjesse
added a commit
that referenced
this pull request
Mar 10, 2016
Add support for OkHttp's MultipartBody.Part.
| * <li>Other object types will be converted to an appropriate representation by using | ||
| * {@linkplain Converter a converter}.</li> | ||
| * {@linkplain Converter a converter}. Supply the part name in the annotation (e.g., | ||
| * {@code @Part("foo") RequestBody foo}).</li> |
There was a problem hiding this comment.
Good catch, thanks. 210be05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this we need to make
@Part's value (i.e., name) optional, sinceMultipartBody.Partbrings its name.MultipartBody.Partis a replacement for Retrofit 1'sTypedOutput/TypedFilefor doing uploads of files with names.Closes #1140. Closes #1467.