Add failing test #2949
Open
Add failing test #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staktrace
commented
May 18, 2024
| } | ||
|
|
||
| ZipFile(File(fixtureRoot, "build/libs/kotlinsourcesjar-sources.jar")).use { | ||
| assertThat(it.stream().filter { it.name.contains("Period.kt") }.count()).isEqualTo(1) |
There was a problem hiding this comment.
The count here comes to be 3 instead of 1
oldergod
force-pushed
the
kartikaya.kotlinsourcesjar
branch
from
3deaa60
to
9ed07a4
Compare
oldergod
force-pushed
the
kartikaya.kotlinsourcesjar
branch
from
9ed07a4
to
e141aba
Compare
oldergod
approved these changes
Jun 28, 2024
Comment on lines
-193
to
-203
| // TODO: pair up generatedSourceDirectories with their targets so we can be precise. | ||
| for (generatedSourcesDirectory in generatedSourcesDirectories) { | ||
| val relativePath = generatedSourcesDirectory.toRelativeString(project.projectDir) | ||
| if (hasJavaOutput) { | ||
| source.javaSourceDirectorySet?.srcDir(relativePath) | ||
| } | ||
| if (hasKotlinOutput) { | ||
| source.kotlinSourceDirectorySet?.srcDir(relativePath) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
We're kinda doing it below which one of the duplicacy was coming from
Comment on lines
84
to
+85
| kotlinSourceDirectorySet = sourceDirectorySet, | ||
| javaSourceDirectorySet = sourceDirectorySet, | ||
| javaSourceDirectorySet = null, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test demonstrates #2950, that running
gradle kotlinSourcesJaron a trivial wire project generates a sources jar with 3 copies of each wire-generated file.