Filter extend fields based on the emitting rules #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrw
approved these changes
Jun 14, 2024
| @@ -174,12 +174,16 @@ abstract class SchemaHandler { | |||
| } | |||
| } | |||
|
|
|||
| // TODO(jwilson): extend emitting rules to support include/exclude of extension fields. | |||
swankjesse
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cashapp/misk#3286
This PR filters extend fields (like options) based on the file they are generated in, looking at their package name. Before that, even if one has multiple targets, the first target would generate all the extend fields, all the time.