Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated test #60

Merged
merged 13 commits into from
Feb 1, 2023
Merged

Add automated test #60

merged 13 commits into from
Feb 1, 2023

Conversation

srid
Copy link
Owner

@srid srid commented Feb 1, 2023

Resolves #25. To be squash merged.

  • Add ./test that aims to use all features of haskell-flake
  • Add ./test/test.sh that verifies that the devshell of ./test is as one would expect
  • Add ./runtest.sh at project root to run the full test
  • Run the same ^ in Github Actions

I'm not entirely happy with this approach; in particular, test.sh seems pretty hacky. But it works. Not sure if it will scale.

I just would like to have some sort of automated tests before doing substantial changes to haskell-flake.

@srid srid requested a review from roberth February 1, 2023 00:45
@roberth
Copy link
Collaborator

roberth commented Feb 1, 2023

I'm not entirely happy with this approach

Me neither, but it seems to get the job done.
Improvements are kind of blocked Flakes improvements like

@srid
Copy link
Owner Author

srid commented Feb 1, 2023

Yea, let's go with it for now and make it perfect when the time is right.

@srid srid merged commit 47437fb into master Feb 1, 2023
@srid srid deleted the test branch February 1, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automated tests
2 participants