Create HF repo if it doesn't exist #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
versae
commented
May 31, 2024
| @@ -757,6 +759,9 @@ def save_pretrained( | |||
| upload_to_hf = self.reference_checkpoint | |||
| if not isinstance(upload_to_hf, bool): | |||
| assert isinstance(upload_to_hf, (str, RepoRef)) | |||
| if isinstance(upload_to_hf, str) and not repo_exists(upload_to_hf, repo_type="model"): | |||
There was a problem hiding this comment.
I assume a RepoRef can only exist when an actual repo also exists in HF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HFCheckpointConverter.save_pretrained()function needs an existing repo for the push to HF to be successful. This PR checks whether the repo already exists, and if not, it creates a private one so the training doesn't fail because of the push to HF failed.Feel free to ignore if the functionality is not desired.