Adding NormalFixedMean #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandroschuler
approved these changes
May 5, 2023
|
I accidentally had the NormalFixedMean class parameterized by sigma/stdev (params[0] was the standard deviation). I changed it to match the Normal class's log(sigma). |
alejandroschuler
approved these changes
Aug 9, 2023
|
@joseortiz3 can you pull the latest version of master and resolve conflicts here? |
Linter is demanding a blank line for ending a file (sigh)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the distribution for NormalFixedMean (mean=0) closely following the code for NormalFixedVar (var=1) and Normal. Would appreciate someone double-checking the math for the d_score and metric. I also didn't see NormalFixedVar mentioned in the tests, so I added them to
test_distns.py.Example plots:
