automatically barrier reconstruction #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
star-e
reviewed
Apr 1, 2022
| const ResourceGraph &resourceGraph; | ||
|
|
||
| ExternalResMap & externalMap; //last frame to curr frame status transition | ||
| PmrFlatSet<PmrString> externalResNames; //first meet in this frame |
There was a problem hiding this comment.
PmrFlatSet<PmrString> externalResNames需要保存在visitor外面。visitor经常会被copy来copy去，externalResNames会有多份而不是一份，造成结果不符合预期。
star-e
reviewed
Apr 1, 2022
| rag.resourceIndex.emplace(rescName, rescID); | ||
| rag.resourceNames.emplace_back(rescName); | ||
| } else { | ||
| rescID = rag.resourceIndex[rescName]; |
There was a problem hiding this comment.
这行没理解，上面已经取值了uint32_t rescID = rg.valueIndex.at(rescName);。
这两个值应该是一样的？
star-e
reviewed
Apr 1, 2022
| @@ -633,8 +422,10 @@ void FrameGraphDispatcher::buildBarriers() const { | |||
| // : or no extra barrier needed. | |||
| BarrierMap batchedBarriers; | |||
|
|
|||
| static ExternalResMap externalMap; | |||
There was a problem hiding this comment.
尽量不要用static变量，不排除有多个FrameGraphDispatcher在多个线程同时被使用。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: cocos-creator/3d-tasks#
Changelog:
with doc: https://github.com/cocos/3d-tasks/pull/11854