Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/boxcoxinv #1878

Merged
merged 6 commits into from
Mar 14, 2024
Merged

feat: add C implementation for math/base/special/boxcoxinv #1878

merged 6 commits into from
Mar 14, 2024

Conversation

Rejoan-Sardar
Copy link
Contributor

@Rejoan-Sardar Rejoan-Sardar commented Mar 14, 2024 •
edited by kgryte
Loading

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for math/base/special/boxcoxinv

Related Issues

Does this pull request have any related issues?

#649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

Rejoan-Sardar and others added 2 commits March 14, 2024 08:51
@Rejoan-Sardar
feat: @stdlib/math/base/special/boxcoxinv
38cccac
@Rejoan-Sardar
feat: update
ae8aedc 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Math Issue or pull request specific to math functionality. C Issue involves or relates to C. labels Mar 14, 2024
@kgryte kgryte changed the title feat: add C implementation for math/base/special/boxcoxinv feat: add C implementation for math/base/special/boxcoxinv Mar 14, 2024
@kgryte
Apply suggestions from code review
438c6f2 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
115c1e3 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
0aa88f3 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
4811ed0 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Rejoan-Sardar!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 14, 2024
@kgryte kgryte merged commit f2812cf into stdlib-js:develop Mar 14, 2024
7 checks passed
This was referenced Mar 17, 2024
Closed
Closed
@Rejoan-Sardar Rejoan-Sardar mentioned this pull request Apr 1, 2024
Closed
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rejoan-Sardar @kgryte