-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow cycling through multiline commands using up/down in the REPL #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
Snehil-Shah
added
Enhancement
Issue or pull request for enhancing existing functionality.
REPL
Issue or pull request specific to the project REPL.
labels
Jul 7, 2024
kgryte
reviewed
Jul 7, 2024
kgryte
reviewed
Jul 7, 2024
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
kgryte
reviewed
Jul 14, 2024
kgryte
reviewed
Jul 14, 2024
kgryte
reviewed
Jul 14, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Jul 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'll leave it to @Planeshifter to perform a final review and verification of intended behavior.
Planeshifter
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, too; let's land this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
Issue or pull request for enhancing existing functionality.
REPL
Issue or pull request specific to the project REPL.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2070
Description
This pull request:
Behaviors:
Related Issues
This pull request:
Questions
No.
Other
cycle.mp4
Checklist
@stdlib-js/reviewers