Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Toggle checkboxes in description on click #756

Closed
3 of 8 tasks
neerro opened this issue Dec 11, 2020 · 11 comments
Closed
3 of 8 tasks

✅ Toggle checkboxes in description on click #756

neerro opened this issue Dec 11, 2020 · 11 comments
Labels
enhancement New feature or request

Comments

@neerro
Copy link

neerro commented Dec 11, 2020

Describe the bug
I've attached screenshot for clear understanding. There are no way for easy using markdown check-list in description box inside of tasks.
First of all we may observe some point before starting markdown code on the first line.
The second one I have no possibility to mark the tasks in check-list just to put on click, for this option I should manually put X inside [ ]. For example in Web UI I have a possibility marking finalized tasks just put on click.

To reproduce
Issue is reproducible with an account from try.nextcloud.com:

  • Yes
  • No

Expected behavior
I would to get a possibiluty marking tasks which were done by put on click. Also it would be greate to add feature when tasks in check-list will be done to indicate like this one: Text of the task

Screenshots
Screenshot_20201212_001349_it.niedermann.nextcloud.deck.play.jpg

Versions

  • Nextcloud: latest
  • Nextcloud Deck: latest
  • Nextcloud Android: latest
  • Nextcloud Android Deck: latest

Smartphone (please complete the following information):

  • Device: Honor 10 lite
  • Android-Version: 10
  • App-Store:
    • Google Play Store
    • Google Play Store (Beta channel)
    • F-Droid
    • Huawei AppGallery

Are you using LDAP?

  • Yes
  • No
@stefan-niedermann
Copy link
Owner

Well, actually it's not a bug but a feature request. 😉

We replaced the complete markdown editor recently and released version 1.13.1 at the Play Store Beta channel - this will bring a few enhancements to the editor but not solve your issue yet (toggle checkboxes by click).

I will keep this issue open as a feature request, so we don't forget it. 🙂

First of all we may observe some point before starting markdown code on the first line.

Unfortunately I do not understand this

Also it would be greate to add feature when tasks in check-list will be done to indicate like this one: Text of the task

This propably won't happen. It changes the semantic of the content and while it might fit in most scenarios, it won't fit for each scenario. I recommend to explicitly use the ~~strike~~ syntax for that.

@stefan-niedermann stefan-niedermann added the enhancement New feature or request label Dec 11, 2020
@stefan-niedermann stefan-niedermann changed the title Incorrect working markdown check-list in description of tasks ✅ Toggle checkboxes in description on click Dec 11, 2020
@neerro
Copy link
Author

neerro commented Dec 12, 2020

Thank you Stefan for your fast response and your correction. Yes of course it should be feature request :)

Unfortunately I do not understand this
"Also it would be greate to add feature when tasks in check-list will be done to indicate like this one: Text of the task"

So, I mean when we mark the task as done (for example: clicked on toggle checkbox) the text is automatically become strikethrough (as: - [x] Text). For example this feature has implemented in Trello. From my lowly point of view many functions could be taken from Trello and will implemented in Deck for best user practice.

This propably won't happen. It changes the semantic of the content and while it might fit in most scenarios, it won't fit for each scenario. I recommend to explicitly use the strike syntax for that.

Yes, but it's not so convenient for daily quick using.

@stefan-niedermann
Copy link
Owner

Step by step 🙂 As i said, i agree that toggling checkboxes is a must have feature and we will support it at some point in the future.

But as a simple example where a striked text will completely change the semantic, take this description as an example:

Title: BBQ next friday
Description:
We need to find out how much sausages we will have.
Neighbours who will bring sausages:

- [x] Thomas
- [ ] Sarah
- [x] Bernhard

In this case actuall Sarah needs to be displayed as Sarah, so it ain't that easy. I will have a talk with a few designers about this topic, but for now we will only commit to implement toggleable checkboxes via click.

@neerro
Copy link
Author

neerro commented Dec 12, 2020

Title: BBQ next friday
Description:
We need to find out how much sausages we will have.
Neighbours who will bring sausages:

  • Thomas
  • Sarah
  • Bernhard
    In this case actuall Sarah needs to be displayed as Sarah, so it ain't that easy. I will have a talk with a few designers about this >topic, but for now we will only commit to implement toggleable checkboxes via click.

No. It's actually not. For this case we have to separate Sara from common list. For example (I'd made a little bit different. See below):

start case
Title: BBQ next friday
Description:
We need to find out how much sausages we will have.
Neighbours who will bring sausages:

  • Thomas
  • Bernhard

Neighbours who will bring souse for sausages:

  • Sarah
    end case

The example where we can use a strike text is:

start case
What do I have to do when the next morning will come? (Let's imagine that some tasks already done and how it have to be look)

  • woke up
  • stand up from bed
  • wash oneself
  • make coffee
  • ... etc.
    end case

That is my case what did I mean and how it should be work for strike text (in automation mode when we click on toggle box).

This is my point of view how those scenarios should be working.

@desperateCoder
Copy link
Collaborator

desperateCoder commented Dec 12, 2020

If I may add my own two cents:

This is my point of view how those scenarios should be working.

@neerro: Yep, thats your point of view. I bet if you ask ten people, you'll get twelve points of views.

and while it might fit in most scenarios, it won't fit for each scenario.

@stefan-niedermann: Yep, not all, but the most.

IMHO you both got absolutely valid points. In cases like these I'm about to say: let the user decide. Make it a setting to toggle the behavior. Since I am just the backend-dude here and @stefan-niedermann is the master of UI/UX you should know my opinion isn't really important here. We also want to integrate fine into the Nextcloud ecosytem and match the most expectations of our users, we might not be able to fit all of them.

I will have a talk with a few designers about this topic, but for now we will only commit to implement toggleable checkboxes via click.

@neerro so you'll get at least something. Is it ok for you to take a step back and let @stefan-niedermann go through it step-by-step? I promise we will consider this and maybe I can convince him to make it at least toggleable, while we can't promise the Nextcloud UX designers will like the idea. And even if they do, there are some technical obstacles for this, since we just integrated and enhanced a brand new Markdown-engine. So please be patient, we do this all in our spare time and got a bunch of other issues to solve, so we concentrate on the most urgent ones, while this one isn't the game changer (for now!).

Still, I love configurable software @stefan-niedermann 😜

@politas

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@politas

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@dudeofawesome
Copy link

Opening in view mode would be nice, given that is the default view for the web app as well.

@stefan-niedermann stefan-niedermann pinned this issue Feb 19, 2021
stefan-niedermann added a commit that referenced this issue Mar 3, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Mar 3, 2021
Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
Copy link
Owner

Checkboxes can be toggled within view mode starting with 1.15.0.

Opening in view mode would be nice, given that is the default view for the web app as well.

Please open a separate issue about that topic. We will need some UX input here, because valid options are

  • Always open in view mode
  • Always open in edit mode
  • Remember last state per card
  • Remember last state per board
  • Remember last state globally

Those are too many options to maintain and i'd like to pick some useful defaults :) -> Discussion needed.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants