fix: description on readonly boards #1674
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this, you cannot select text, not interact with link etc.
Ornanovitch
commented
Sep 14, 2024
| binding.descriptionEditor.setEnabled(false); | ||
| binding.descriptionEditorWrapper.setVisibility(GONE); | ||
| binding.descriptionViewer.setEnabled(false); | ||
| binding.descriptionViewer.setEnabled(true); |
There was a problem hiding this comment.
This change is not necessary to view the description, but it seems mandatory to interact with it (links, selection...)
Ornanovitch
commented
Sep 14, 2024
| @@ -123,7 +123,7 @@ | |||
| android:textIsSelectable="true" | |||
| android:textSize="@dimen/font_size_description" | |||
| android:translationY="1dp" | |||
| android:visibility="gone" /> | |||
| android:visibility="visible" /> | |||
|
Thank you for the contribution! I'm currently on vacation and will try to review the changes after Sept 25th. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After many attempts, I was finally able to make it! Tested with a prod server, with and without readonly boards, everything works as expected :)
But I must admit I am not fully confident with the code, I never tried to play with java code before, so I don't even understand completely why those peace of code were missing...
I'd love to have your feedbacks @stefan-niedermann