fix: card title color #1675
fix: card title color #1675
Conversation
the color was unreadable since some updates of nextcloud/android-common this commit make the card title readable again with a more used and (stable?) function
|
Thank you for the contribution! Shouldn't this fixed upstream in the |
There was a problem hiding this comment.
You're certainly right, I'll try to better understand the changes in android-common bu we should first test before/after the recent versions of the library. I'll try to get some time to do that.
I'll also try to just remove those lines, because this is the unique case of explicit usage of colorEditText in the whole app, while the other EditText fields are working (labels, assing, due date).
In any case upstream should be investigated but I'm just starting to learn all of this
| @@ -17,6 +17,7 @@ | |||
| import com.google.android.material.dialog.MaterialAlertDialogBuilder; | |||
| import com.google.android.material.tabs.TabLayout; | |||
| import com.google.android.material.tabs.TabLayoutMediator; | |||
| import com.nextcloud.android.common.ui.theme.utils.ColorRole; | |||
There was a problem hiding this comment.
| import com.nextcloud.android.common.ui.theme.utils.ColorRole; |
| @@ -289,7 +290,7 @@ private void applyTheme(int color) { | |||
|
|
|||
| utils.platform.themeStatusBar(this); | |||
| utils.material.themeToolbar(binding.toolbar); | |||
| utils.platform.colorEditText(binding.title); | |||
| utils.platform.colorTextView(binding.title, ColorRole.ON_SURFACE); | |||
There was a problem hiding this comment.
| utils.platform.colorTextView(binding.title, ColorRole.ON_SURFACE); |
|
Oh! Could it be that? - editText.setTextColor(scheme.onSurface)
+ editText.setTextColor(dynamicColor.surface().getArgb(scheme)) // -> .onSurface becoming .surface |
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
|
superseded by nextcloud/android-common#502 Let's close this until we can see the library changes |
On master, the
colorEditTextcolor is unreadable since some updates of nextcloud/android-common (here I guess)This commit makes the card title readable again with a more used and (stable?) function,
colorTextViewwith the paramColorRole.ON_SURFACE