Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let "rightMenu" switch correctly when slideOutThenIn = YES. #91

Closed
wants to merge 1 commit into from

Conversation

eyeye
Copy link

@eyeye eyeye commented Sep 11, 2013

issue: slideOutThenIn = YES, "rightMenu" switch wrong.

In SASlideMenuContentSegue,

run [destination performSegueWithIdentifier:@"rightMenu" sender:rootController];
before switchToContentViewController animate slideOut , completed.
cause SASlideMenuRightMenuSegue.perform [source.parentViewController == nil]

workaroud:
run [destination performSegueWithIdentifier:@"rightMenu" sender:rootController];
after (void) switchToContentViewController:(UINavigationController*) content completion:(void (^)(void))completion;

MARK: My first github pull request.....

issue:  slideOutThenIn = YES, "rightMenu" switch wrong.

In SASlideMenuContentSegue,

run  [destination performSegueWithIdentifier:@"rightMenu"
sender:rootController];
before switchToContentViewController animate completed.

workaroud:
run  [destination performSegueWithIdentifier:@"rightMenu"
sender:rootController];
after switchToContentViewController.(completed)

SASlideMenuRightMenuSegue.perform [source.parentViewController == nil]
@stefanoa
Copy link
Owner

Hi eyeye,

What type of problem you get when you set slideOutThenIn = YES ?

@eyeye
Copy link
Author

eyeye commented Sep 14, 2013

If i built UI each content MenuContent view has it's own rightMenu, and in slideOutThenIn() return YES.
When selected different MenuContent , The rightMenu will not switched.

stefanoa added a commit that referenced this pull request Sep 15, 2013
@stefanoa
Copy link
Owner

Hi eyeye,

I finally understood the problem and fixed it using your suggestion.
Thank you for your contribution.

@stefanoa stefanoa closed this Sep 30, 2013
@eyeye eyeye deleted the fix_rightMenu branch September 30, 2013 12:04
@MeTazz1
Copy link

MeTazz1 commented Oct 24, 2013

Good morning :)

I just updated SASlideMenu, and got a crash on :

if (hasRightMenu) {
[destination performSegueWithIdentifier:@"rightMenu" sender:rootController];
}

I have the lastest version. Any ideas ? (It was working before the update :) )

@stefanoa
Copy link
Owner

Do you have the Xcode Log?

@MeTazz1
Copy link

MeTazz1 commented Oct 24, 2013

Actually it's not a crash, it shows a breakpoint on this line, I can continue, but transition isn't working. (Unknown exception throw). The destination is a UINavigationController

@stefanoa
Copy link
Owner

To use the new version you have to create a view inside the SASlideMenuRootVIewController and connect it to the menuView outlet. This view will contain the left menu and you can size the left menu according to your needs. If you do not do that you will not see any left menu.
However this is about the left menu but it seems you have an issue with the right menu.
If you have a small project that will create the problem i will have a look at it, I also will double check the examples to see if I missed something.

@MeTazz1
Copy link

MeTazz1 commented Oct 24, 2013

I'll do asap, thank you :)

@eyeye eyeye restored the fix_rightMenu branch November 15, 2015 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants