Created a subspec in your podspec file for SQLiteCipher #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating from master
Did NOT add the Cipher.swift file to the xcode project, so this will only be available if someone puts "pod 'SQLite.swift/SQLiteCipher'" in their pod file
|
Any update on this? |
|
This needs rebasing since there are now subspecs defined in the current master. Also not sure if I'm not sure how SQLiteCipher would integrate, presumably we'd need another compile time flag? #if SQLITE_SWIFT_STANDALONE
import sqlite3
#else if SQLITE_SWIFT_SQLITECIPHER
import SQLiteCipher
#else
import CSQLite
#endif |
|
No activity, closing. Please reopen a new PR if needed. |
|
this has been reworked into #553 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why I took this approach is one had to compile the SQLite.swift library to use a codec if they were to get the goodness of SQLCipher, yet the only difference between your other repo and this one was the presence of the Cipher.swift file.
This approach does NOT add the Cipher.swift file to the Xcode project, but rather includes it in the pod's subspec so that if someone chooses to install it, it is present in the build SQLite.swift framework.
If this PR is accepted and merged, than #389 wouldn't be necessary, and neither would the separate git repo for SQLiteCipher.swift (especially stephencelis/SQLiteCipher.swift#12)