Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back keyboard shortcuts for data entry/editing #9

Open
muachilin opened this issue Feb 25, 2020 · 1 comment
Open

Add back keyboard shortcuts for data entry/editing #9

muachilin opened this issue Feb 25, 2020 · 1 comment
Assignees
@krisgun @Zodbigt @muachilin

Comments

@muachilin
Copy link
Collaborator

The previous version of JabRef supports Emacs chords for moving the cursors. However, these features seem to be removed in 5.0 snapshots. It is necessary to add back these features to enhance usability.
@muachilin muachilin self-assigned this Feb 25, 2020
@krisgun
Copy link
Collaborator

krisgun commented Feb 26, 2020

Reference to original issue: JabRef#6017

krisgun added a commit that referenced this issue Feb 26, 2020
@krisgun
[feat] Add gui support
e28e35f 
This commit adds a new preference under the Entry editor tab in the preferences. This also maps to the preferences:

EDITOR_EMACS_KEYBINDINGS
EDITOR_EMACS_KEYBINDINGS_REBIND_CA
EDITOR_EMACS_KEYBINDINGS_REBIND_CF

[Issue: #9]
krisgun added a commit that referenced this issue Feb 26, 2020
@krisgun
[fix] Added missing text strings
fc225c4 
The text strings describing the emacs options in preferences were missing, and are now added.

[Issue: #9]
Zodbigt added a commit that referenced this issue Feb 26, 2020
@Zodbigt
[feat] Keyboard shortcuts for data entry/editing
c2ce584 
Ths commit adds the first step for re-integrating emac keybindings.
In this version emacs works globly but dosent have all features yet.

[issue: #9]
@Zodbigt Zodbigt self-assigned this Feb 26, 2020
krisgun added a commit that referenced this issue Feb 26, 2020
@krisgun
[feat] Emacs key bindings can now be toggled in preferences
3752711 
Emacs key bindings can now be toggled through a preference option in the Entry Editor preference tab

[Issue: #9]
krisgun added a commit that referenced this issue Feb 26, 2020
@krisgun
[feat] Ctrl+a and Ctrl+f can now also be toggled in preferences
48c3777 
There are sub-options deciding whether C-a and C-f  should be rebinded as well, which now work as intended

[Issue: #9]
@krisgun krisgun self-assigned this Feb 26, 2020
krisgun added a commit that referenced this issue Feb 26, 2020
@krisgun
[fix] Change import order and add missing localization keys
c6db3df 
Imports were not conforming to the CheckStyle and some localization keys for the Emacs commands were missing

[Issue: #9]
krisgun added a commit that referenced this issue Feb 26, 2020
@krisgun
[fix] Reorder import and add localization keys
5f94ebf 
[Issue: #9]
Zodbigt added a commit that referenced this issue Feb 27, 2020
@Zodbigt
[feat] Moves the Emacs lgic to is own class
6071360 
This moves all the emacs moves to its own class.

[issue: #9]
krisgun added a commit that referenced this issue Feb 27, 2020
@krisgun
[fix] Rename EmacsKeyBindings and reorder imports
86ab7a3 
The old EmacsKeyBindings class is now removed and replaced with a working one. Missing localization keys were also added.

[Issue: #9]
krisgun added a commit that referenced this issue Feb 27, 2020
@krisgun
[fix] Checkboxes are now disabled when parent is unchecked
160208d 
If the enabledEmacsKeyBindings checkbox is unchecked, its children will now be disabled to further convey that the children settings are not applied anymore.

[Issue: #9 ]
Zodbigt added a commit that referenced this issue Feb 27, 2020
@Zodbigt
[feat] Add test for the StringChangeNextWord class
b11ccb8 
Thois commit adds a start for tests for the StringChangeNextWord class.

[issue: #9]
Zodbigt added a commit that referenced this issue Feb 27, 2020
@Zodbigt
[feat] Add test for the StringChangeNextWord class
430963a 
This commit adds more test case for the StringChangeNextWord class.

[issue: #9]
krisgun added a commit that referenced this issue Feb 27, 2020
@krisgun
[fix] StringChangeNextWord trailing space now removed
0906b26 
[Issue: #9]
krisgun added a commit that referenced this issue Feb 27, 2020
@krisgun
[fix] Change parameter order in assertEquals
1f38a06 
[Issue: #9]
Zodbigt added a commit that referenced this issue Feb 27, 2020
@Zodbigt
[fix] Add comments for postion of the caret in StringChangeNextWordTe…
478e000 
…st class

[issue: #9]
krisgun added a commit that referenced this issue Feb 27, 2020
@krisgun
[fix] Emacs key bindings can now be used in all classes that inherit …
f7f4348 
…TextInputControl

[Issue: #9]
Zodbigt added a commit that referenced this issue Feb 27, 2020
@Zodbigt
[feat] Add test cases for the StringChangeNextWordTest class
b0c4bdc 
[issue: #9]
krisgun added a commit that referenced this issue Feb 27, 2020
@krisgun
[refac] Moved more of the Emacs logic into its class
5114bbe 
A lot of preferences were passed from JabRefGUI instead of getting them directly from the preferences.

[Issue: #9]
Zodbigt added a commit that referenced this issue Feb 27, 2020
@Zodbigt
[feat] Add new class for returning both caret postion and result text
512641a 
This commit adds a new class to handle borth caret postion and result text for the emacs comands.

[issue: #9]
krisgun added a commit that referenced this issue Feb 28, 2020
@krisgun
[fix] Update localization keys
c405e41 
[Issue: #9]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krisgun krisgun

@Zodbigt Zodbigt

@muachilin muachilin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krisgun @Zodbigt @muachilin