Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 3.3 warnings about observer gem being removed from the standard library #293

Closed
Benjaminpjacobs opened this issue May 2, 2024 · 2 comments · Fixed by #294
Closed

Ruby 3.3 warnings about observer gem being removed from the standard library #293

Benjaminpjacobs opened this issue May 2, 2024 · 2 comments · Fixed by #294

Comments

@Benjaminpjacobs
Copy link

After upgrading to ruby 3.3.1 we are seeing the following warning:

/app/vendor/bundle/ruby/3.3.0/gems/bootsnap-1.16.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:32: warning: /app/vendor/ruby-3.3.1/lib/ruby/3.3.0/observer.rb was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add observer to your Gemfile or gemspec. Also contact author of cable_ready-5.0.3 to add observer into its gemspec.

The observer gem has been added to our Gemfile to quiet the warnings but are there any plans to add it to the cable_ready gemspec in upcoming releases?
@marcoroth
Copy link
Member

Thanks for opening this issue @Benjaminpjacobs, let's add the observer gem to the CableReady gemspec then 👍🏼

@marcoroth marcoroth mentioned this issue May 2, 2024
Merged
2 tasks
@marcoroth
Copy link
Member

Opened #294 to address this.

marcoroth added a commit that referenced this issue May 2, 2024
@marcoroth
Add observer gem to gemspec (#294)
9cfa12c 
Ruby 3.4 removes the `observer` gem from the standard gems which is why
we have the declare the dependency explicitly now.

From https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/:

> ### Standard library updates
> RubyGems and Bundler warn if users do require the following gems
without adding them to Gemfile or gemspec. This is because they will
become the bundled gems in the future version of Ruby.

Fixes #293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add observer gem to gemspec stimulusreflex/cable_ready
2 participants
@marcoroth @Benjaminpjacobs