Make sure mocked actions can be identified in production build #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodograumann
force-pushed
the
fix-action-mocks@206
branch
from
4a35b63
to
79c7c46
Compare
IanVS
reviewed
Aug 18, 2022
examples/vue/.storybook/main.ts
Outdated
| resolve: { alias: [{ find: '@assets', replacement: resolve(__dirname, '..', 'stories', 'assets') }] }, | ||
| resolve: { | ||
| alias: [{ find: '@assets', replacement: resolve(__dirname, '..', 'stories', 'assets') }], | ||
| dedupe: ['@storybook/client-api'], |
There was a problem hiding this comment.
This dedupe is only necessary if there are different storybook versions being installed. I see that @storybook/addon-interactions doesn't match the rest, but from discord it sounded like this error started before you added that addon. If you install addon-interactions 6.5.9, is this dedupe still needed?
There was a problem hiding this comment.
I invistigated with yarn why and set @storybook/vue3 as well as @storybook/addon-interactions to 6.5.9 as fixed version.This seems to work.
IanVS
approved these changes
Aug 23, 2022
|
Thanks @bodograumann! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if the tests should be kept in, as they add a lot of dependencies to the example.
Fixes #206.