Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unsafe Storyshots import #1124

Merged
merged 1 commit into from
May 25, 2017
Merged

Removed unsafe Storyshots import #1124

merged 1 commit into from
May 25, 2017

Conversation

tmeasday
Copy link
Member

See #995 (comment)

Issue: Accidentally included an unused import that isn't safe.

What I did

Removed it

How to test

CI should pick up if SS still runs.

@tmeasday tmeasday requested a review from shilman May 25, 2017 00:00
@codecov
Copy link

codecov bot commented May 25, 2017 •
edited
Loading

Codecov Report

Merging #1124 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
+ Coverage   12.73%   12.74%   +<.01%     
==========================================
  Files         199      199              
  Lines        4475     4472       -3     
  Branches      711      711              
==========================================
  Hits          570      570              
+ Misses       3275     3272       -3     
  Partials      630      630
Impacted Files Coverage Δ
addons/storyshots/src/test-bodies.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f908535...3618a1a. Read the comment docs.

@shilman shilman changed the title Fix issue with Removed unsafe Storyshots import May 25, 2017
shilman
shilman approved these changes May 25, 2017
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging!

@shilman shilman merged commit 41cbc3a into master May 25, 2017
@shilman shilman added misc and removed in progress labels May 25, 2017
@ndelangen ndelangen added the cleanup Minor cleanup style change that won't show up in release changelog label May 27, 2017
@ndelangen ndelangen deleted the fix-shallow-import branch May 27, 2017 22:43
@snyk-bot snyk-bot mentioned this pull request Nov 5, 2022
Open
This was referenced Nov 5, 2022
Open
Open
@adrukh adrukh mentioned this pull request Nov 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 5, 2022
Open
@adrianblynch adrianblynch mentioned this pull request Nov 5, 2022
Open
@Bhanditz Bhanditz mentioned this pull request Nov 5, 2022
Open
This was referenced Dec 25, 2022
Open
Open
This was referenced Dec 25, 2022
Open
Open
@adrukh adrukh mentioned this pull request Dec 26, 2022
Open
@adrianblynch adrianblynch mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmeasday @shilman @ndelangen