Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App-angular: upgrade ts-loader to 3.3.1 #2855

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Jan 27, 2018

Changelog

Angular example seems to work just OK


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 27, 2018

Codecov Report

Merging #2855 into master will decrease coverage by 1.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2855      +/-   ##
==========================================
- Coverage   37.48%   35.82%   -1.66%     
==========================================
  Files         434      428       -6     
  Lines        9389     9423      +34     
  Branches      915      987      +72     
==========================================
- Hits         3519     3376     -143     
- Misses       5313     5389      +76     
- Partials      557      658     +101
Impacted Files Coverage Δ
app/polymer/src/server/utils.js 0% <0%> (-100%) ⬇️
addons/notes/src/index.js 0% <0%> (-61.54%) ⬇️
addons/notes/src/react.js 0% <0%> (-33.34%) ⬇️
addons/knobs/src/components/types/Select.js 7.93% <0%> (-16.71%) ⬇️
addons/knobs/src/base.js 6.66% <0%> (-5.1%) ⬇️
addons/info/src/components/types/OneOfType.js 57.14% <0%> (-2.86%) ⬇️
...i/src/modules/ui/components/stories_panel/index.js 20.96% <0%> (-0.7%) ⬇️
addons/events/src/components/Event.js 38.55% <0%> (-0.48%) ⬇️
addons/info/src/components/types/PrettyPropType.js 85.71% <0%> (-0.29%) ⬇️
lib/core/src/client/preview/client_api.js 90.62% <0%> (-0.2%) ⬇️
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96d6a7e...cb3dd00. Read the comment docs.

Copy link
Member

@danielduan danielduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop configFileName support (replaced by configFile) BREAKING CHANGE

might be safer to save this for the next major or minor instead of patch? otherwise, seems okay.

@Hypnosphi
Copy link
Member Author

Hypnosphi commented Feb 20, 2018

@igor-dv
Copy link
Member

igor-dv commented Feb 20, 2018

@Hypnosphi
Copy link
Member Author

Hypnosphi commented Feb 20, 2018

Ok, but the only field is configFile which isn't deprecated https://github.com/storybooks/storybook/blob/master/app/angular/src/server/ts_config.js#L23

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants