Addon Storysource improvements #3040
Conversation
| } | ||
|
|
||
| function prettifyCode(source) { | ||
| return prettier.format(source, { |
There was a problem hiding this comment.
Can we make it optional and configurable?
There was a problem hiding this comment.
Only the prettier or the whole comments removal? Also. why?
There was a problem hiding this comment.
The prettier. Users may have their own preferences about how their code should be formatted
There was a problem hiding this comment.
Actually, I thought we won't expose it to users 😂 But I can make it configurable.
There was a problem hiding this comment.
I thought we won't expose it to users
Why? I would like to use it in my project (and we don't use semicolons =)
There was a problem hiding this comment.
👌
Probably I needed to spend a bit more time on writing a Readme 🤔
| let lastIndex = 0; | ||
| const parts = [source]; | ||
|
|
||
| const isUgly = comment => comment.value.trim().indexOf('eslint-') === 0; |
There was a problem hiding this comment.
also "global", "flow", "$FlowFixMe", probably others. Let's make it an array of regexp patterns, probably also configurable from outside
There was a problem hiding this comment.
I've added "global" and "eslint" as defaults. Do you think we need to support flow as well? I'm not familiar with its comments syntax.
Codecov Report
@@ Coverage Diff @@
## master #3040 +/- ##
========================================
Coverage ? 92.5%
========================================
Files ? 6
Lines ? 40
Branches ? 2
========================================
Hits ? 37
Misses ? 2
Partials ? 1Continue to review full report at Codecov.
|
| }; | ||
|
|
||
| function isUglyComment(comment, uglyCommentsRegex) { | ||
| return uglyCommentsRegex.find(regex => regex.test(comment)); |
Please fix remark warning |
What I did