Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs to use new Notes form and use yarn for addon install #3309

Merged
merged 3 commits into from
Mar 29, 2018

Conversation

paul42
Copy link
Contributor

@paul42 paul42 commented Mar 28, 2018

Issue: #3305

What I did

Updated documents

How to test

View help documents and verify they look acceptable

Is this testable with Jest or Chromatic screenshots?
no?

Does this need a new example in the kitchen sink apps?
no

Does this need an update to the documentation?
N/A, this is a documentation update

If your answer is yes to any of these, please make sure to include it in your PR.

Updated instructions to use yarn and new form instead of old component wrapper form
@Hypnosphi Hypnosphi added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 29, 2018
@codecov
Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #3309 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3309   +/-   ##
=======================================
  Coverage   35.63%   35.63%           
=======================================
  Files         472      472           
  Lines       10121    10121           
  Branches      947      964   +17     
=======================================
  Hits         3607     3607           
+ Misses       5949     5889   -60     
- Partials      565      625   +60
Impacted Files Coverage Δ
addons/actions/src/lib/decycle.js 53.52% <0%> (ø) ⬆️
...t-native/src/preview/components/StoryView/index.js 0% <0%> (ø) ⬆️
addons/info/src/components/types/Shape.js 66.03% <0%> (ø) ⬆️
lib/core/src/client/preview/reducer.js 37.5% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/storysource/src/loader/inject-decorator.js 28% <0%> (ø) ⬆️
...modules/ui/components/stories_panel/text_filter.js 30.98% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
addons/knobs/src/mithril/WrapStory.js 0% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1daab23...77801ae. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 2bebe02 into storybookjs:master Mar 29, 2018
@paul42
Copy link
Contributor Author

paul42 commented Mar 29, 2018

thanks @Hypnosphi I appreciate the help!

Hypnosphi added a commit that referenced this pull request Mar 30, 2018
Update Docs to use new Notes form and use yarn for addon install
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 6, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants