Scroll preview pane for non-percentage heights #3342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #3326 #3341
While investigating this issue #3326, I found out that this is caused by this scrollIntoView call inside StorySource addon, which weirdly makes the entire right split panel (preview + addon panels) to scroll up whenever you go back to
storysource
panel after changing the viewport.Added to that, on small screens (issue #3341), part of the viewport is hidden behind the addon's panel, that's because the iframe container is not scrollable and is less in height than the iframe
Both issues are correlated to each other though
What I did
How to test
Make the steps described in #3326 but without the misplacement of the story panel
Is this testable with Jest or Chromatic screenshots?
No
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
No
If your answer is yes to any of these, please make sure to include it in your PR.