Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpile safe-eval package #5498

Merged
merged 2 commits into from
Feb 9, 2019
Merged

Transpile safe-eval package #5498

merged 2 commits into from
Feb 9, 2019

Conversation

Hypnosphi
Copy link
Member

Issue: #5472

@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against b8675aa

@Hypnosphi Hypnosphi added the bug label Feb 6, 2019
@ndelangen
Copy link
Member

CLI tests are throwing an error:


ERROR in /tmp/storybook/node_modules/safe-eval/index.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: Requires Babel "^7.0.0-0", but was loaded with "6.26.3". If you are sure you have a compatible version of @babel/core, it is likely that something in your build process is loading the wrong version. Inspect the stack trace of this error to look for the first entry that doesn't mention "@babel/core" or "babel-core" to see what is calling Babel. (While processing preset: "/tmp/storybook/node_modules/@babel/preset-env/lib/index.js")
    at throwVersionError (/tmp/storybook/node_modules/@babel/helper-plugin-utils/lib/index.js:65:11)
    at Object.assertVersion (/tmp/storybook/node_modules/@babel/helper-plugin-utils/lib/index.js:13:11)
    at _default (/tmp/storybook/node_modules/@babel/preset-env/lib/index.js:154:7)
    at /tmp/storybook/node_modules/@babel/helper-plugin-utils/lib/index.js:19:12
    at /tmp/storybook/lib/cli/test/run/react_babel_6/node_modules/babel-core/lib/transformation/file/options/option-manager.js:317:46
    at Array.map (<anonymous>)
    at OptionManager.resolvePresets (/tmp/storybook/lib/cli/test/run/react_babel_6/node_modules/babel-core/lib/transformation/file/options/option-manager.js:275:20)
    at OptionManager.mergePresets (/tmp/storybook/lib/cli/test/run/react_babel_6/node_modules/babel-core/lib/transformation/file/options/option-manager.js:264:10)
    at OptionManager.mergeOptions (/tmp/storybook/lib/cli/test/run/react_babel_6/node_modules/babel-core/lib/transformation/file/options/option-manager.js:249:14)
    at OptionManager.init (/tmp/storybook/lib/cli/test/run/react_babel_6/node_modules/babel-core/lib/transformation/file/options/option-manager.js:368:12)
    at File.initOptions (/tmp/storybook/lib/cli/test/run/react_babel_6/node_modules/babel-core/lib/transformation/file/index.js:212:65)
    at new File (/tmp/storybook/lib/cli/test/run/react_babel_6/node_modules/babel-core/lib/transformation/file/index.js:135:24)
    at Pipeline.transform (/tmp/storybook/lib/cli/test/run/react_babel_6/node_modules/babel-core/lib/transformation/pipeline.js:46:16)
    at transpile (/tmp/storybook/lib/cli/test/run/react_babel_6/node_modules/babel-loader/lib/index.js:50:20)
    at /tmp/storybook/lib/cli/test/run/react_babel_6/node_modules/babel-loader/lib/fs-cache.js:118:18
    at ReadFileContext.callback (/tmp/storybook/lib/cli/test/run/react_babel_6/node_modules/babel-loader/lib/fs-cache.js:31:21)
    at FSReqWrap.readFileAfterOpen [as oncomplete] (fs.js:420:13)
 @ /tmp/storybook/node_modules/telejson/dist/index.js 20:39-59
 @ /tmp/storybook/lib/channel-postmessage/dist/index.js
 @ /tmp/storybook/lib/core/dist/client/preview/start.js
 @ /tmp/storybook/lib/core/dist/client/preview/index.js
 @ /tmp/storybook/lib/core/dist/client/index.js
 @ /tmp/storybook/lib/core/client.js
 @ /tmp/storybook/app/react/dist/client/preview/index.js
 @ /tmp/storybook/app/react/dist/client/index.js
 @ ./.storybook/config.js
 @ multi /tmp/storybook/lib/core/dist/server/common/polyfills.js /tmp/storybook/lib/core/dist/server/preview/globals.js ./.storybook/config.js (webpack)-hot-middleware/client.js?reload=true

Do you know a fix?

@Hypnosphi
Copy link
Member Author

Will investigate on the weekend

@codecov
Copy link

codecov bot commented Feb 9, 2019

Codecov Report

Merging #5498 into next will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5498      +/-   ##
==========================================
- Coverage   31.44%   31.37%   -0.07%     
==========================================
  Files         635      635              
  Lines        9173     9191      +18     
  Branches     1270     1271       +1     
==========================================
  Hits         2884     2884              
- Misses       5650     5667      +17     
- Partials      639      640       +1
Impacted Files Coverage Δ
.../core/src/server/manager/manager-webpack.config.js 0% <0%> (ø) ⬆️
lib/core/src/server/common/babel-loader.js 0% <0%> (ø) ⬆️
...b/core/src/server/preview/iframe-webpack.config.js 0% <0%> (ø) ⬆️
addons/viewport/src/register.js 0% <0%> (ø) ⬆️
addons/backgrounds/src/Tool.js 0% <0%> (ø) ⬆️
lib/core/src/server/cli/dev.js 0% <0%> (ø) ⬆️
addons/viewport/src/Tool.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab4440...1bcb78f. Read the comment docs.

@Hypnosphi
Copy link
Member Author

@ndelangen fixed

@ndelangen ndelangen merged commit d9cd83c into next Feb 9, 2019
@ndelangen ndelangen deleted the transpile-safe-eval branch February 9, 2019 23:29
@ndelangen
Copy link
Member

👏

@ndelangen ndelangen added this to the v5.0.0 milestone Feb 9, 2019
@shilman shilman added release patch:done Patch/release PRs already cherry-picked to main/release branch labels Feb 15, 2019
shilman pushed a commit that referenced this pull request Feb 15, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants