Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix flaky story #8459

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Build: Fix flaky story #8459

merged 2 commits into from
Oct 18, 2019

Conversation

ndelangen
Copy link
Member

Issue: 1 story has been flaky, this makes it deterministic (hopefully)

What I did

REMOVE the relevant localstorage on every story render in chromatic

@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Oct 17, 2019
@ndelangen ndelangen added this to the 5.3.0 milestone Oct 17, 2019
@ndelangen ndelangen self-assigned this Oct 17, 2019
@vercel
Copy link

vercel bot commented Oct 17, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/92tdmextw
🌍 Preview: https://monorepo-git-fix-flaky-desktop-story.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fingers crossed! 🤞

@shilman shilman changed the title FIX flaky story Build: Fix flaky story Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants