Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove : prop types in lib/components #9747

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Remove : prop types in lib/components #9747

merged 1 commit into from
Feb 14, 2020

Conversation

sakit0
Copy link
Contributor

@sakit0 sakit0 commented Feb 4, 2020

What I did

PropTypes in lib/components/tabs.tsx seems to be unused.

You can do this to remove prop-types package.

@sakit0 sakit0 changed the title [remove] lib/components in prop types Remove : lib/components in prop types Feb 4, 2020
@sakit0 sakit0 changed the title Remove : lib/components in prop types Remove : prop types in lib/components Feb 4, 2020
@shilman shilman added components maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 4, 2020
shilman
shilman approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @ndelangen ?

@ndelangen
Copy link
Member

This should target the default next branch. Then be cherry-picked into the master branch if necessary.

@sakito21 would you be able to rebase this unto next?

@ndelangen ndelangen changed the base branch from master to next February 5, 2020 17:02
@shilman
Copy link
Member

shilman commented Feb 5, 2020 •
edited
Loading

@ndelangen FYI we can also patch this from master to next if needed. that's what i was planning to do with the original PR nevermind

@ndelangen ndelangen self-assigned this Feb 14, 2020
@ndelangen ndelangen force-pushed the lib/components-remove-PropTypes branch from b3a1cb6 to 9a5dc17 Compare February 14, 2020 21:28
@sakit0 sakit0 requested a review from igor-dv as a code owner February 14, 2020 21:28
@ndelangen ndelangen force-pushed the lib/components-remove-PropTypes branch from 9a5dc17 to 1e43b97 Compare February 14, 2020 21:30
@ndelangen ndelangen added this to the 6.0.0 milestone Feb 14, 2020
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Feb 14, 2020
@ndelangen ndelangen merged commit dbfaf3c into storybookjs:next Feb 14, 2020
@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen ndelangen approved these changes

@tmeasday tmeasday Awaiting requested review from tmeasday

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees

@ndelangen ndelangen

Labels
components maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sakit0 @ndelangen @shilman