Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subs table compatibility for PBC #2695

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Subs table compatibility for PBC #2695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions classes/class.memberorder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1785,12 +1785,6 @@ public function get_subscription() {
return null;
}

// Make sure that this order has been completed.
if ( 'success' !== $this->status ) {
// The order is not complete, so it isn't a valid subscription payment.
return null;
}

$get_subscription_args = array(
'subscription_transaction_id' => $this->subscription_transaction_id,
'gateway' => $this->gateway,
Expand All @@ -1802,6 +1796,12 @@ public function get_subscription() {
return $existing_subscription;
}

// Only create a subscription if this order is complete.
if ( 'success' !== $this->status ) {
// The order is not complete, so it isn't a valid subscription payment.
return null;
}

if ( isset( $pmpro_level ) ) {
// We are processing a checkout. Get the level from the checkout.
$subscription_level = $this->getMembershipLevelAtCheckout();
Expand Down
63 changes: 62 additions & 1 deletion classes/gateways/class.pmprogateway_check.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,5 +356,66 @@ function cancel(&$order)
//simulate a successful cancel
$order->updateStatus("cancelled");
return true;
}
}

/**
* Synchronizes a subscription with this payment gateway.
*
* @since TBD
*
* @param PMPro_Subscription $subscription The subscription to synchronize.
* @return string|null Error message is returned if update fails.
*/
public function update_subscription_info( $subscription ) {
// Track the fields that need to be updated.
$update_array = array();

// Update the start date to the date of the first order for this subscription if it
// it is earlier than the current start date.
$oldest_orders = $subscription->get_orders( [
'limit' => 1,
'orderby' => '`timestamp` ASC, `id` ASC',
] );
if ( ! empty( $oldest_orders ) ) {
$oldest_order = current( $oldest_orders );
if ( empty( $subscription->get_startdate() ) || $oldest_order->getTimestamp( true ) < strtotime( $subscription->get_startdate() ) ) {
$update_array['startdate'] = date_i18n( 'Y-m-d H:i:s', $oldest_order->getTimestamp( true ) );
}
}

// Update the subscription's next payment date.
// If there is a pending order for this subscription, the subscription's next payment date should be the timestamp of the oldest pending order.
$pending_orders = $subscription->get_orders(
array(
'status' => 'pending',
'orderby' => '`timestamp` ASC, `id` ASC',
'limit' => 1,
)
);
if ( ! empty( $pending_orders ) ) {
// Get the oldest pending order.
$oldest_pending_order = current( $pending_orders );

// Set the next payment date to the timestamp of the oldest pending order.
$update_array['next_payment_date'] = date_i18n( 'Y-m-d H:i:s', $oldest_pending_order->getTimestamp( true ) );
} else {
// If there are no pending orders, the subscription's next payment date should be updated to one payment period after the timestamp of the most recent 'success' order.
$newest_orders = $subscription->get_orders(
array(
'status' => 'success',
'limit' => 1
)
);
if ( ! empty( $newest_orders ) ) {
// Get the most recent order.
$newest_order = current( $newest_orders );

// Calculate the next payment date.
$update_array['next_payment_date'] = date_i18n( 'Y-m-d H:i:s', strtotime( '+ ' . $subscription->get_cycle_number() . ' ' . $subscription->get_cycle_period(), $newest_order->getTimestamp( true ) ) );
}
}

// Update the subscription.
$subscription->set( $update_array );
}
}