Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Add support for pmpro-card classes #120

Conversation

MaximilianoRicoTabo
Copy link
Contributor

  • Remove id that's error prone and not needed
  • A bit of WPCS
image image

All Submissions:

Changes proposed in this Pull Request:

Resolves XXX.

How to test the changes in this Pull Request:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@kimcoleman
Copy link
Member

Reworked this HTML and now using pmpro_get_element_class.

Note in my testing there is an issue with free levels and donations. If you have a free level and the minimum donation amount is $0, the PBC choose a payment method never appears. We probably need to add a listener just like https://github.com/strangerstudios/pmpro-donations/blob/dev/includes/checkout.php#L132-L143 somewhere.

@dparker1005 dparker1005 merged commit 5af8ebd into strangerstudios:dev Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants