Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix membership shortcode for non-member users #83

Conversation

dparker1005
Copy link
Member

Issue:

  1. Using shortcode [membership level="0"]
  2. Logged in user without a membership level tries to view the content and should be able to
  3. is_user_logged_in() will be true
  4. pmprobpc_memberHasAccessWithAnyLevel( $current_user->ID ) will set $hasaccess to false since the user does not have a membership level

This behavior is incorrect. If we are trying to show content to non-members, then we absolutely don't want to hide the content because this logged-in non-member don't have a level.

@andrewlimaza andrewlimaza added the ✓ Ready for Merge Pull requests that have been reviewed and confirmed by PM as ready for merge label Nov 8, 2022
@dparker1005 dparker1005 merged commit 5fc2705 into strangerstudios:dev Aug 11, 2023
@dparker1005 dparker1005 deleted the fix-member-shortcode-for-non-member-users branch August 11, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✓ Ready for Merge Pull requests that have been reviewed and confirmed by PM as ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants