Fixes an error on the confirmation page #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once you've reached the confrmation page an error is thrown: Warning: Attempt to read property "name" on string in C:\Users\info\Local Sites\paid-memberships-pro\app\public\wp-content\plugins\pmpro-pay-by-check\pmpro-pay-by-check.php on line 663 This references the membership level name. We currently reference the user -> membership level but this hasn't been assigned yet because the order is still pending. Instead, we've opted to reference the invoice -> membership level.
|
This came up in ticket 477489, so I sent the PR. |
|
A customer (ticket 482012) is dealing with this. |
|
A customer (ticket 482012) ran into this, so I added a PR with their changes. They added a call to pmpro_getSpecificMembershipLevelForUser() after getting the user since the next line This pr #85 could be merged and this pr can be closed as it preserves Jarryd's commit. |
|
Closing as this fix has already been merged in #80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once you've reached the confrmation page an error is thrown:
Warning: Attempt to read property "name" on string in C:\Users\info\Local Sites\paid-memberships-pro\app\public\wp-content\plugins\pmpro-pay-by-check\pmpro-pay-by-check.php on line 663
This references the membership level name.
We currently reference the user -> membership level but this hasn't been assigned yet because the order is still pending.
Instead, we've opted to reference the invoice -> membership level.