Removes the PPExp Toggle Section for a Check Only level #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### All Submissions: * [x] Have you followed the [Contributing guideline](https://github.com/strangerstudios/paid-memberships-pro/blob/master/.github/CONTRIBUTING.md)? * [x] Does your code follow the [WordPress' coding standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/)? * [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/strangerstudios/paid-memberships-pro/pulls) for the same update/change? <!-- Mark completed items with an [x] --> <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Changes proposed in this Pull Request: The PayPal Express Add On adds a toggle section which doesn't get removed for levels that only allow a Check payment. This removes that section where necessary. ### How to test the changes in this Pull Request: 1. Activate PMPro, PayPal Express Add On and Pay By Check Add On 2. Set a level to only allow payment by Check 3. The toggle/radio buttons should no longer show on checkout ### Other information: * [x] Have you added an explanation of what your changes do and why you'd like us to include them? * [x] Have you successfully run tests with your changes locally? <!-- Mark completed items with an [x] --> ### Changelog entry Check only levels no longer show multiple gateway options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
The PayPal Express Add On adds a toggle section which doesn't get removed for levels that only allow a Check payment.
This removes that section where necessary.
How to test the changes in this Pull Request:
Other information:
Changelog entry
Check only levels no longer show multiple gateway options