Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect y-coordinate when drawing text-box #9

Closed
wants to merge 2 commits into from

Conversation

Saba-Sabato
Copy link
Contributor

Hi! Really appreciate this package, thanks.
Following the fix in #6 , we need to update the y-coordinate for drawing the textbox too.
I have also added some tests and docs, if this is too much feel free to drop the other commit or edit as you see fit. Thanks!

@straussmaximilian
Copy link
Owner

Hi,
this is great, thanks!
I made a couple of adjustments:

  • Typing caused issues with Python 3.8, so I made it backward compatible
  • I changed the test a bit to know which word fails
  • For some reason, there were slight differences in the test images, so tests failed
  • I made the tests more specific by adding the language preference
  • I made a confidence parameter to filter out based on confidence
  • This still didn't fix the issue, so I now included an MSE score to roughly compare the images.

For some reason it didn't push to this branch, so the PR is now here #10

@Saba-Sabato
Copy link
Contributor Author

Thanks for taking the time to go over it and make the required corrections!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants