Rework integer type selection #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
Oats87,
sridhargaddam,
tpantelis,
vthapar and
yboaron
as code owners
|
🤖 Created branch: z_pr3144/skitt/int-cleanup |
tpantelis
reviewed
Aug 30, 2024
tpantelis
reviewed
Aug 30, 2024
skitt
force-pushed
the
int-cleanup
branch
2 times, most recently
from
0c08ac8
to
c39c3d4
Compare
Merged
tpantelis
approved these changes
Sep 11, 2024
tpantelis
force-pushed
the
int-cleanup
branch
2 times, most recently
from
af5a9a7
to
a6e6f31
Compare
Following the recent gosec-related int work (to annotate known-safe conversions), this furthers that by: * using ints instead of uints for healthcheck configuration and tracking * using uint32 instead of int for IP pool sizes, since their use is tied to uint32 representations of IP addresses * using fmt.Sprintf instead of manual string concatenation to construct the connectivity verification command * using int32 for nat discovery IPPortPair Signed-off-by: Stephen Kitt <skitt@redhat.com>
tpantelis
force-pushed
the
int-cleanup
branch
from
a6e6f31
to
a26d35f
Compare
|
The linting failures need the shipyard golangci-lint bump. |
|
🤖 Closed branches: [z_pr3144/skitt/int-cleanup] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the recent gosec-related int work (to annotate known-safe conversions), this furthers that by: