Allow users to set a license for each track separately #1197
Conversation
Used to store the license for the asset. Defaults to all-rights-reserved so we don't have to backfill existing records and have a default value for new uploads.
Accepts license names and converts them to usable license labels and icons.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| import { Controller } from "@hotwired/stimulus" | |||
There was a problem hiding this comment.
Parsing error: [BABEL]: Cannot find module 'shakapacker'
Require stack:
- /code/config/webpack/preset.js
- /usr/local/node_modules/@babel/core/lib/config/files/module-types.js
- /usr/local/node_modules/@babel/core/lib/config/files/configuration.js
- /usr/local/node_modules/@babel/core/lib/config/files/index.js
- /usr/local/node_modules/@babel/core/lib/index.js
- /usr/local/node_modules/@babel/eslint-parser/lib/worker/babel-core.cjs
- /usr/local/node_modules/@babel/eslint-parser/lib/worker/handle-message.cjs
- /usr/local/node_modules/@babel/eslint-parser/lib/client.cjs
- /usr/local/node_modules/@babel/eslint-parser/lib/index.cjs
- /usr/local/node_modules/eslint/lib/cli-engine/config-array-factory.js
- /usr/src/app/lib/eslint6-patch.js
- /usr/src/app/lib/eslint.js
- /usr/src/app/bin/eslint.js (While processing: /code/config/webpack/preset.js)
|
|
|
I also considered using the default Unicode symbols instead of SVG, but I'm pretty sure those aren't supported on a lot of devices. https://creativecommons.org/2020/03/18/the-unicode-standard-now-includes-cc-license-symbols/ |
|
This all looks great! Oooh, that's cool about unicode CC symbols. SVG is perfect though, more pragmatic for now. |
|
Added #1199 and #1200 to summarize design cleanup to assets#show and assets#edit to help clear room for this feature. @bencarlos — probably easiest if those changes just happen on this branch. Ping me if you think I need to move some rails logic around for fave and edit, otherwise i think it should be pretty straightforward! |
|
@Manfred We tried to include CC icons in a couple places like in the main list, but in the end they seemed to mainly add visual bulk/noise, so they didn't make the cut... 😢
|
I think it's fine to add a column with a default in one go for all assets, but that may be a very slow migration. We should probably test that before deploying.
References #1196