Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Sync calendar with entries on journal page #62

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

meimeisuns
Copy link
Member

@meimeisuns meimeisuns commented Sep 21, 2022

Currently adds two things:

  1. Shows you entries from the month you switch to
    If you switch to another month, no longer will it continue to display the entry from the last date that you clicked. It will now default to showing you entries starting from the end of the month.
    Kapture 2022-09-21 at 13 31 14

  2. Cut off entries at beginning of month
    If you clicked on an entry near the beginning of the month, you might have gotten some entries from last month mixed in. It was hard to tell which entries were from which month. Now, it will make sure to only show you entries from the current month after you click the calendar, unless you elect to load more past entries.
    Kapture 2022-09-21 at 13 44 02

Things to look into:

  • Relative time headers for the journal (e.g., "Today", "last week", "last month", "Apr 2021") and also sprinkled throughout the timeline
  • Only show the entry from that day when you click a date? If you clicked on a day without anything going on you would expect to see nothing, but we currently will see any past entries. That might be confusing.
  • Feels a little weird to display entries starting from the end of the month when switching to months. I almost expect the ordering to be from the beginning, but that doesn't really make sense either. Then again, I don't look primarily at the journal when I switch months... Anything different we can do here? Perhaps not show anything until a user clicks to keep their focus on the calendar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant