Remove getset

[serprex]

getset & its proc-macro-error dependencies seem unmaintained (jbaublitz/getset#84 (comment) jbaublitz/getset#87 (comment))

In particular, I'm not confident I can get upstream to update to syn 2

I also don't think getter/setter patterns make particular sense in Rust

Use #[non_exhausitive] in places to maintain capability to add fields without breaking semver

In some places I omitted #[non_exhaustive] where I didn't think it should be necessary, if you disagree let me know & I'll apply it more widely. Similarly, just let me know if you don't think #[non_exhaustive] is necessary

In some cases only getters were implemented, in those cases I implemented getter methods by hand & left the fields non-public

[sunng87]

@serprex Thank you! I have checked all usage of #[non_exhausitive] I think it's just right for all necessary structs.

While I think it's ok to have direct member access over getter/setter, in particular when getset development become stalled, I need to think about impact of this because it's a breaking change.

[serprex]

If you don't want to have a breaking change I can look to create a minimal getset macro based on the rather straightforward use of the crate here

[sunng87]

No worry. We can have breaking change during 0.x phase.

[sunng87]

I just realized that a major drawback of pub struct + pub field access is it stops from adding new fields in semver non-breaking change. Because the initializer syntax Struct { field: value ... } is published as API.

[serprex]

That is prevented by

#[non_exhaustive]

[sunng87]

Yes, we need to add this attribute carefully on each struct during 0.x phase. Adding this attribute is a breaking change too.