-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split api feature #177
Split api feature #177
Conversation
@@ -18,7 +17,7 @@ pub struct FieldDescription { | |||
// the attribute number of the column, default to 0 if not a column from table | |||
pub column_id: i16, | |||
// the object ID of the data type | |||
pub type_id: Oid, | |||
pub type_id: u32, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub type Oid = u32;
Oid is just an alias for u32, to avoid introducing postgres_types
, we restore it here.
LGTM. This is great addition to keep the library compact. I will be adding more feature gates to various authentication methods too. I'm curious how you are using this library in your application, for message format only? |
My application need to run simple query, but also need to obtain columns/rows(text format) or affected rows (I don't know whether to call execute or query.). Thank you very much for writing pgwire! |
That's great to hear. I think there can be some use-case on client side and it becomes true. I will merge this and rename the |
This PR split the "server" into the
api feature
, which can significantly reduce the compilation time for those who just want to use themessages
to write a Postgres client.Two unused crates have been deleted.
Export FORMAT_CODE
This helps the client determine the value format