Update upload methods to allow duplex option to be passed in #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undici >v5.12.0 requires this.
|
Thanks a lot for this PR! |
|
Happy to add tests. I've cloned and tried to run the current tests and most of them are timing out currently, however. Is there any trick to getting them to pass? Possibly something weird in my environment? |
|
@rexmondo Sorry for the late reply - I will take over the PR and add the tests it 🙏 |
fenos
approved these changes
Mar 31, 2023
|
@fenos Stepped into same issue. Any idea when will this PR changes will be available in npm release? Or is there any other way to take these changes into my repository? |
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undici >v5.12.0 requires this.
What kind of change does this PR introduce?
bug fix
What is the current behavior?
#146
What is the new behavior?
Allows the following to go through to the request