fix: throw error if url type used for hubspot, update docs

supaglue-labs · Dec 11, 2023 · e0673ce · e0673ce
1 parent 83aaa86
commit e0673ce
Show file tree

Hide file tree

Showing 15 changed files with 85 additions and 43 deletions.
diff --git a/docs/docs/api/v2/crm/create-custom-object-schema.api.mdx b/docs/docs/api/v2/crm/create-custom-object-schema.api.mdx
diff --git a/docs/docs/api/v2/crm/create-property.api.mdx b/docs/docs/api/v2/crm/create-property.api.mdx
diff --git a/docs/docs/api/v2/crm/get-custom-object-schema.api.mdx b/docs/docs/api/v2/crm/get-custom-object-schema.api.mdx
diff --git a/docs/docs/api/v2/crm/get-property.api.mdx b/docs/docs/api/v2/crm/get-property.api.mdx
diff --git a/docs/docs/api/v2/crm/list-properties-preview.api.mdx b/docs/docs/api/v2/crm/list-properties-preview.api.mdx
diff --git a/docs/docs/api/v2/crm/register-property.api.mdx b/docs/docs/api/v2/crm/register-property.api.mdx
diff --git a/docs/docs/api/v2/crm/update-custom-object-schema.api.mdx b/docs/docs/api/v2/crm/update-custom-object-schema.api.mdx
diff --git a/docs/docs/api/v2/crm/update-property.api.mdx b/docs/docs/api/v2/crm/update-property.api.mdx
diff --git a/openapi/common/components/schemas/property_type.yaml b/openapi/common/components/schemas/property_type.yaml
@@ -13,6 +13,14 @@ enum:
 description: |
   Type of the field.
 
+  :::note
+  `picklist` and `multipicklist` property types are currently only supported in Salesforce and Hubspot
+  :::
+
+  :::note
+  `url` property type currently is only natively supported in Salesforce.
+  :::
+
   Support:
 
   <table>
@@ -75,9 +83,9 @@ description: |
       </tr>
       <tr>
         <td>url</td>
-        <td>string-text</td>
+        <td>Not Supported</td>
         <td>Url</td>
-        <td>varchar_auto</td>
+        <td>Not Supported</td>
       </tr>
     </tbody>
     </table>
diff --git a/openapi/v2/crm/openapi.bundle.json b/openapi/v2/crm/openapi.bundle.json
diff --git a/openapi/v2/crm/paths/metadata/properties@{object_name}.yaml b/openapi/v2/crm/paths/metadata/properties@{object_name}.yaml
@@ -38,6 +38,10 @@ post:
   summary: Create property
   description: |
     Creates a custom property in the provider and registers it in Supaglue.
+
+    :::note
+    This endpoint is only supported for Salesforce and Hubspot currently.
+    :::
   tags:
     - Properties
   security:

diff --git a/openapi/v2/crm/paths/metadata/properties@{object_name}@{property_name}.yaml b/openapi/v2/crm/paths/metadata/properties@{object_name}@{property_name}.yaml
@@ -37,6 +37,10 @@ patch:
     :::note
     This feature is only available in Preview to select customers on our Enterprise plan. [Contact us](mailto:team@supaglue.com) for more information.
     :::
+
+    :::note
+    This endpoint is only supported for Salesforce and Hubspot currently.
+    :::
   tags:
     - Properties
   security:

diff --git a/packages/core/remotes/impl/hubspot/mappers.ts b/packages/core/remotes/impl/hubspot/mappers.ts
@@ -577,33 +577,27 @@ export const toHubspotTypeAndFieldType = (
   propertyType: PropertyType
 ): { type: PropertyUpdateTypeEnum; fieldType: PropertyUpdateFieldTypeEnum } => {
   switch (propertyType) {
-    case 'text': {
+    case 'text':
       return { type: 'string', fieldType: 'text' };
-    }
-    case 'textarea': {
+    case 'textarea':
       return { type: 'string', fieldType: 'textarea' };
-    }
-    case 'number': {
+    case 'number':
       return { type: 'number', fieldType: 'number' };
-    }
-    case 'picklist': {
+    case 'picklist':
       return { type: 'enumeration', fieldType: 'select' };
-    }
-    case 'multipicklist': {
+    case 'multipicklist':
       return { type: 'enumeration', fieldType: 'checkbox' };
-    }
-    case 'date': {
+    case 'date':
       return { type: 'date', fieldType: 'date' };
-    }
-    case 'datetime': {
+    case 'datetime':
       return {
         type: 'datetime',
         fieldType: 'date',
       };
-    }
-    case 'boolean': {
+    case 'boolean':
       return { type: 'bool', fieldType: 'booleancheckbox' };
-    }
+    case 'url':
+      throw new BadRequestError('url type is unsupported');
     default:
       return { type: 'string', fieldType: 'text' };
   }

diff --git a/packages/core/remotes/impl/pipedrive/mappers.ts b/packages/core/remotes/impl/pipedrive/mappers.ts
@@ -216,13 +216,13 @@ export const fromPipedriveUserToUser = (user: PipedriveRecord): User => {
 export const fromPipedriveEmailsToEmailAddresses = (emails: { label: string; value: string }[]): EmailAddress[] => {
   return emails
     .filter(({ label }) => label === 'work' || label === 'primary')
-    .map((email) => ({ emailAddress: email.value, emailAddressType: email.label } as EmailAddress));
+    .map((email) => ({ emailAddress: email.value, emailAddressType: email.label }) as EmailAddress);
 };
 
 export const fromPipedrivePhonesToPhoneNumbers = (phoneNumbers: { label: string; value: string }[]): PhoneNumber[] => {
   return phoneNumbers
     .filter(({ label }) => label === 'mobile' || label === 'primary' || label === 'fax')
-    .map((phoneNumber) => ({ phoneNumber: phoneNumber.value, phoneNumberType: phoneNumber.label } as PhoneNumber));
+    .map((phoneNumber) => ({ phoneNumber: phoneNumber.value, phoneNumberType: phoneNumber.label }) as PhoneNumber);
 };
 
 export const fromPipedriveOrganizationToAddresses = (organization: PipedriveRecord): Address[] => {

diff --git a/packages/schemas/gen/v2/crm.ts b/packages/schemas/gen/v2/crm.ts