This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
feat: implement hubspot webhook target endpoint + webhook setup #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asdfryan
commented
Dec 7, 2023
asdfryan
commented
- Create webhook target on Provider creation
- Create / update webhook subscriptions on SyncConfig update
… hubspot_provider
asdfryan
requested review from
tomkit,
lucasmarshall,
tonyxiao and
george-xing
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
lucasmarshall
suggested changes
Dec 11, 2023
| import { BadRequestError } from '../errors'; | ||
|
|
||
| const HUBSPOT_WEBHOOK_TARGET_URL = | ||
| process.env.HUBSPOT_WEBHOOK_TARGET_URL ?? `${process.env.SUPAGLUE_SERVER_URL}/internal/hubspot/_webhook`; |
There was a problem hiding this comment.
When would you use HUBSPOT_WEBHOOK_TARGET_URL instead of relying on the fallback?
There was a problem hiding this comment.
When we use another service for queueing webhooks, like hookdeck.
packages/core/lib/hubspot_webhook.ts
Outdated
Comment on lines
54
to
56
| throw new BadRequestError( | ||
| `Your Hubspot Developer App already has an existing Webhook target URL. Please delete it first.` | ||
| ); |
There was a problem hiding this comment.
Maybe move this out of the try so we aren't needlessly catching and re-throwing it?
Co-authored-by: Lucas Marshall <lucasmarshall@users.noreply.github.com>
lucasmarshall
approved these changes
Dec 11, 2023
Co-authored-by: Lucas Marshall <lucasmarshall@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.