This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
fix: stream error handling #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmarshall
requested review from
tomkit,
tonyxiao,
asdfryan and
george-xing
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
asdfryan
approved these changes
Dec 12, 2023
lucasmarshall
added a commit
that referenced
this pull request
Dec 13, 2023
This reverts commit e81f636.
lucasmarshall
added a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node documentation indicates that this is the correct way to indicate errors in a stream and not to use
.emit('error', ...)as that is internal to streams.I'm hoping this will fix some cases were we aren't getting errors handled by the
handleErrfunction in the provider.