Deployer: open pr on launch #3953
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests were sometimes really slow (TestDeployNodeApp/With_Depot took more than seven minutes in the run below). Logging the app name would be helpful for troubleshooting. https://github.com/superfly/flyctl/actions/runs/10895447430/job/30233905656?pr=3944#step:7:48
jeromegn
reviewed
Sep 20, 2024
| @@ -377,6 +383,17 @@ | |||
| end | |||
| end | |||
|
|
|||
| if CREATE_AND_PUSH_BRANCH | |||
| in_step Step::CREATE_AND_PUSH_BRANCH do | |||
There was a problem hiding this comment.
I think we should do that after a successful deploy. Else, it probably means that the generated files are wrong.
There was a problem hiding this comment.
Oh, you also only want to do that if GIT_REPO has been specified. This might sound annoying, but our tests won't always rely on the git repo being present.
…mpatible (#3952) Bump github.com/docker/docker Bumps [github.com/docker/docker](https://github.com/docker/docker) from 27.2.1+incompatible to 27.3.0+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v27.2.1...v27.3.0) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.66.2 to 1.67.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.66.2...v1.67.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Checking `flag.IsSpecified` makes its default false.
add remote container image metadata extractor
…mpatible (#3956) Bump github.com/docker/docker Bumps [github.com/docker/docker](https://github.com/docker/docker) from 27.3.0+incompatible to 27.3.1+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v27.3.0...v27.3.1) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why: If our deployer image sets DEPLOY_CREATE_AND_PUSH_BRANCH we will create and push a branch with modified files
How: new env DEPLOY_CREATE_AND_PUSH_BRANCH
Related to: PaaS work
Documentation