Add Nomspace integration #621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zhethan is attempting to deploy a commit to the Sushi Team on Vercel. A member of the Team first needs to authorize it. |
BriungRi
reviewed
Feb 16, 2022
package.json
Outdated
| @@ -211,5 +211,9 @@ | |||
| "not ie 11", | |||
| "not dead", | |||
| "not op_mini all" | |||
| ] | |||
| ], | |||
| "dependencies": { | |||
There was a problem hiding this comment.
Does it work to move these deps to devDependencies? Let's avoid adding stuff to dependencies considering their team hasn't added anything there
BriungRi
reviewed
Feb 16, 2022
| @@ -82,7 +84,13 @@ const AccountDetails: FC<AccountDetailsProps> = ({ | |||
| /> | |||
| </div> | |||
| <Typography weight={700} variant="lg" className="text-white"> | |||
| {ENSName ? ENSName : account && shortenAddress(account)} | |||
| {nom && ENSName | |||
There was a problem hiding this comment.
Let's do it in this priority:
ENSName ? ENSName : nom ? nom : account && shortenAddress(account)
BriungRi
reviewed
Feb 16, 2022
src/components/Web3Status/index.tsx
Outdated
| @@ -127,7 +127,7 @@ function Web3StatusInner() { | |||
| </div> | |||
| ) : ( | |||
| <div className="flex items-center gap-2"> | |||
| <div>{ENSName || shortenAddress(account)}</div> | |||
| <div>{ENSName ? ENSName : nom ? shortenAddress(account) + ' (' + nom + ')' : shortenAddress(account)}</div> | |||
There was a problem hiding this comment.
I think it's probably ok to just do nom instead of shortenAddress(account) + ' (' + nom + ')'
BriungRi
reviewed
Feb 16, 2022
| @@ -42,7 +42,16 @@ const HeaderDropdown: FC<HeaderDropdownProps> = ({ account, hideAccount = false | |||
| className="text-high-emphesis flex gap-1 cursor-pointer hover:text-blue-100" | |||
| weight={700} | |||
| > | |||
| {ENSName ? ENSName : account ? shortenAddress(account) : ''} <LinkIcon width={20} /> | |||
| {nom && ENSName | |||
BriungRi
reviewed
Feb 16, 2022
src/hooks/useENSName.ts
Outdated
| @@ -1,21 +1,29 @@ | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
Don't use @ts-ignore. Add @ensdomains/ensjs declaration to a .d.ts file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.