Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs page for writing adapters refers to old polyfill package name #10278

Closed
erxclau opened this issue Jun 28, 2023 · 1 comment · Fixed by #10455
Closed

Docs page for writing adapters refers to old polyfill package name #10278

erxclau opened this issue Jun 28, 2023 · 1 comment · Fixed by #10455
Labels
documentation Improvements or additions to documentation low hanging fruit ready to implement please submit PRs for these issues!

Comments

@erxclau
Copy link
Contributor

erxclau commented Jun 28, 2023

Describe the problem

The page for writing adapters refers to @sveltejs/kit/install-fetch but this package was renamed to @sveltejs/kit/node/polyfills.

- Globally shims `fetch` to work on the target platform, if necessary. SvelteKit provides a `@sveltejs/kit/install-fetch` helper for platforms that can use `node-fetch`

Describe the proposed solution

  1. Change the package name to @sveltejs/kit/node/polyfills.
  2. Update language to also say that crypto is shimmed as part of the package.

Alternatives considered

No response

Importance

nice to have

Additional Information

No response

@dummdidumm dummdidumm added documentation Improvements or additions to documentation low hanging fruit ready to implement please submit PRs for these issues! labels Jun 28, 2023
@gladimir777
Copy link
Contributor

Hello, I am new to this world of contributing to open source project. And I would like give my firs contribution on solving this. Could you please asign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation low hanging fruit ready to implement please submit PRs for these issues!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants