You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Endpoints are not able to process any requests made to /favicon.ico. An endpoint file named /favicon.ico.js does run at all and a 404 is returned instead. While static assets can be served on the /favicon.ico path, the endpoint cannot; this limits /favicon.ico severely for anything more than one file (or some file swapping).
Adjustments can be made with rel="icon" to use a different path, but /favicon.ico is a well known path and should be supported with endpoints.
* allow /favicon.ico to be a valid route - closes#4968
* Update packages/kit/src/runtime/server/index.js
* Update .changeset/young-flies-camp.md
Co-authored-by: Maurício Kishi <mrkishi@users.noreply.github.com>
Co-authored-by: Maurício Kishi <mrkishi@users.noreply.github.com>
Describe the bug
Endpoints are not able to process any requests made to
/favicon.ico
. An endpoint file named /favicon.ico.js does run at all and a 404 is returned instead. While static assets can be served on the/favicon.ico
path, the endpoint cannot; this limits/favicon.ico
severely for anything more than one file (or some file swapping).Adjustments can be made with
rel="icon"
to use a different path, but /favicon.ico is a well known path and should be supported with endpoints.Reproduction
https://stackblitz.com/edit/sveltejs-kit-template-default-rk12yp?file=src/routes/favicon.ico.js
https://github.com/bakkerthehacker/sveltejs-kit-template-default-rk12yp (empty, syncing from stackblitz not working)
/favicon.ico.js and /favicon2.ico.js both have 302 redirects to /todos
localhost:3000/favicon2.ico -> 302 redirects to /todos as expected
localhost:3000/favicon.ico -> 404
Logs
No response
System Info
Severity
serious, but I can work around it
Additional Information
See this comment on the previous favicon.ico PR: #3559 (comment)
The text was updated successfully, but these errors were encountered: